-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the menubar when menus lose focus (if toggled off) #11355
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11355 +/- ##
===========================================
+ Coverage 63.71% 63.72% +0.01%
===========================================
Files 362 362
Lines 38000 38014 +14
===========================================
+ Hits 24210 24222 +12
- Misses 13790 13792 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work properly. If you follow these steps, you cannot get the menubar back until you've changed the option via Application Settings:
- Disable the Show Menubar option from menu. Confirm that it works properly.
- Enable the Show Menubar option from menu.
- Menu bar goes hidden again. You cannot get it back even when pressing Alt. Is the timer still running? Or the options is not actually checked?
- Go to Application Settings and change the value of Show Menubar. Everything works again.
Oops, forgot to guard the timer with the config setting |
69966dc
to
7193d5a
Compare
@varjolintu fixed |
* Fixes #10768 * Also fix menubar toggling not working if Qt version is less than 5.15
7193d5a
to
fb5dd1e
Compare
Cleaned up the code logic a little bit and reduced the timeout to 250ms. 1 second resulted in weird delays. |
Dunno if it's worth saving the last menu opened? |
Pressing ALT in the situation shown in the video should hide the menu bar, will have to look into that. |
Testing strategy
Tested manually
Type of change